Delete diff artifact after use in "Manage PRs" workflow #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workflow artifact is used to transfer the PR diff file from the `diff` job to the `parse` job. Once the artifact has been downloaded by the `parse` job, it no longer serves any purpose. It's possible the artifact might serve as a vector for exporting secrets from the workflow. Even though I don't have any specific reasons to believe it is possible to cause secrets to be written to the artifact and the repository doesn't currently have any secrets beyond `GITHUB_TOKEN`, nor need for any, it's still best to remove the unnecessary artifact.
per1234
added
type: enhancement
Contributor
|
Hi @per1234. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
github-actions
bot
added
other
and removed
topic: code
silvanocerza
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workflow artifact is used to transfer the PR diff file from the
diffjob to theparsejob. Once the artifact has been downloaded by theparsejob, it no longer serves any purpose.It's possible the artifact might serve as a vector for exporting secrets from the workflow. Even though I don't have any specific reasons to believe it is possible to cause secrets to be written to the artifact and the repository doesn't currently have any secrets beyond
GITHUB_TOKEN, nor need for any, it's still best to remove the unnecessary artifact.We have been using the
geekyeggo/delete-artifactaction with good success in thearduino/arduino-iderepository for some time now: https://github.com/arduino/arduino-ide/blob/0dd1e/.github/workflows/build.yml#L232Demo: per1234#38
(note lack of artifact here: https://github.com/per1234/library-registry/runs/2463658819)